Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pothos example integration with the latest schema changes #194

Closed
Tracked by #166
dariuszkuc opened this issue Aug 15, 2022 · 3 comments · Fixed by #198
Closed
Tracked by #166

update pothos example integration with the latest schema changes #194

dariuszkuc opened this issue Aug 15, 2022 · 3 comments · Fixed by #198
Labels
language: javascript Pull requests that update Javascript code type: schema change Change introduces change to the subgraph schemas

Comments

@dariuszkuc
Copy link
Member

dariuszkuc commented Aug 15, 2022 •
edited

See #166 for details.
@dariuszkuc dariuszkuc mentioned this issue Aug 15, 2022
Closed
24 tasks
@dariuszkuc dariuszkuc changed the title pothos (JavaScript / TypeScript) update pothos example integration with the latest schema changes Aug 15, 2022
@dariuszkuc
Copy link
Member Author

@hayes could you help us out with updating pothos test integration with the latest schema changes?

@dariuszkuc dariuszkuc added language: javascript Pull requests that update Javascript code type: schema change Change introduces change to the subgraph schemas labels Aug 15, 2022
@hayes hayes mentioned this issue Aug 16, 2022
Merged
@hayes
Copy link
Contributor

hayes commented Aug 16, 2022

@dariuszkuc opened a PR, let me know if that works. Didn't update the main readme, but tests seem to pass

@dariuszkuc
Copy link
Member Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: javascript Pull requests that update Javascript code type: schema change Change introduces change to the subgraph schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Pothos implementation hayes/apollo-federation-subgraph-compatibility
2 participants
@hayes @dariuszkuc