Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% Fed 2 compliance for all tested subgraphs #225

Closed
2 of 10 tasks
hwillson opened this issue Sep 8, 2022 · 3 comments
Closed
2 of 10 tasks

100% Fed 2 compliance for all tested subgraphs #225

hwillson opened this issue Sep 8, 2022 · 3 comments

Comments

@hwillson
Copy link
Member

hwillson commented Sep 8, 2022

We need to update the following projects in the subgraph testing repo to fully support Federation 2:

  • Graphene
  • GraphQL .Net
  • Hot Chocolate
  • Lighthouse
  • Mercurius
  • apollo-federation-php
  • gqlgen
  • graphql-ruby
  • async-graphql
  • GraphQL java kickstart

Note that there is some overlap here with #166.

@rvanlaak
Copy link

I guess you mean Skillshare/apollo-federation-php with the action item from your list? There are some more relevant libraries that are working on adding Federation 2 support (and some of them claim to have), so might be best to add test support on more PHP libraries from this list? https://graphql.org/code/#php

@dariuszkuc
Copy link
Member

Hello 👋
This issue was a catch-all to track updates to various federation implementations that we test in this repo that were missing federation v2 support. Since each one of those implementations is a separate project that may require different functionality to be added, I don't think it makes sense to keep this single issue open. While we can keep the separate issues open in this repository, I think having specific issues open against the target projects makes more sense.

@dariuszkuc dariuszkuc closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
@rvanlaak
Copy link

rvanlaak commented Jun 1, 2023

@dariuszkuc agreed, I've added #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants