Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netflix DGS Federation 2 support #86

Closed
hwillson opened this issue Apr 20, 2022 · 4 comments · Fixed by #96
Closed

Netflix DGS Federation 2 support #86

hwillson opened this issue Apr 20, 2022 · 4 comments · Fixed by #96
Assignees
@hwillson
Labels
type: enhancement New feature or request

Comments

@hwillson
Copy link
Member

This work consists of 2 main parts:

  1. Validate that Federation JVM 2.0 (with Fed 2 support) can be used with DGS to provide full Federation 2 support.
  2. Work with the DGS folks to facilitate updating to Federation JVM 2.0
@hwillson hwillson self-assigned this Apr 20, 2022
@hwillson hwillson added the type: enhancement New feature or request label Apr 20, 2022
@hwillson
Copy link
Member Author

1 - has been validated here: #85
2 - discussions have started here: Netflix/dgs-framework#997

We still need to publish Federation JVM 2.0 final before proceeding with #2 above, which is being tracked here: apollographql/federation-jvm#164

@dariuszkuc
Copy link
Member

Completed in Netflix/dgs-framework#1056.

@kdawgwilk
Copy link
Contributor

@dariuszkuc does the implementation in this compatibility test suite need to be updated to reflect this new support before this is closed?

@dariuszkuc
Copy link
Member

dariuszkuc commented May 23, 2022 •
edited

👍 compatibility matrix was already updated to reflect the change, re-opening to track pending change to the subgraph implementation.

@dariuszkuc dariuszkuc reopened this May 23, 2022
@dariuszkuc dariuszkuc mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwillson hwillson

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update DGS to federation-jvm 2.0.0 dariuszkuc/apollo-federation-subgraph-compatibility
3 participants
@hwillson @kdawgwilk @dariuszkuc