Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared type –  GraphQLID #3

Closed
viniychuk opened this issue Sep 26, 2016 · 6 comments
Closed

Undeclared type –  GraphQLID #3

viniychuk opened this issue Sep 26, 2016 · 6 comments

Comments

@viniychuk
Copy link

Hi guys,

I've been trying to use MyAPI playground from quick-start package.
I did introspection query and then re-built target and got this error:
http://take.ms/5AFsd
Using latest apollo-codegen.

Here's how this field is declared in schema.json:

      {
        "kind": "OBJECT",
        "name": "AccessPoint",
        "description": null,
        "fields": [
          {
            "name": "id",
            "description": null,
            "args": [],
            "type": {
              "kind": "SCALAR",
              "name": "ID",
              "ofType": null
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
@martijnwalraven
Copy link
Contributor

martijnwalraven commented Sep 27, 2016

Ah, good catch! I forgot to update the apollo-ios submodule dependency in the quickstart when I updated apollo-codegen.

If you pull the latest version of apollo-ios-quickstart and run git submodule update --init --recursive your issue should now be fixed.

@viniychuk
Copy link
Author

@martijnwalraven don't want to upset you, but after I've updated everything I got this – http://take.ms/9yyGl. GrphQLID got fixed tho :)
p.s. Tried to clean and rebuild, tried making a new clean clone of repo – doesn't help.

@martijnwalraven
Copy link
Contributor

martijnwalraven commented Sep 27, 2016

Hmmm, this submodule stuff is hard :) I'm working on apollo-codegen from master and there have been some changes in the generated code.

I've reverted the apollo-ios submodule to an earlier version that should still fix the GraphQLID issue but work with the released version of apollo-codegen.

@viniychuk
Copy link
Author

@martijnwalraven and.... it works like a charm! And I love it already, it's doing great. Do you think there will be any big changes to the interface anytime soon? I'm about to start using it for the new iOS client (and we're already using apollo js client for the web version) 👍

@martijnwalraven
Copy link
Contributor

martijnwalraven commented Sep 27, 2016

Good to hear!

This is definitely work in progress, but the current interface is pretty minimal, so I don't expect that to change drastically.

I'm currently working on getting fragments and type conditions working, and there will be quite a few changes to the generated code as a result, but that shouldn't affect the interface.

@martijnwalraven
Copy link
Contributor

Closing this, because the issue should be fixed. The recommended installation steps now also include a script that checks the installed version of apollo-codegen against the Apollo iOS framework version installed in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants