Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-js error handling in Swift #3126

Closed
BobaFetters opened this issue Jul 18, 2023 · 0 comments · Fixed by #3132
Closed

Update graphql-js error handling in Swift #3126

BobaFetters opened this issue Jul 18, 2023 · 0 comments · Fixed by #3132
Assignees
Labels
bug Generally incorrect behavior planned-next Slated to be included in the next release

Comments

@BobaFetters
Copy link
Member

By default graphql-js has a max error limit of 100, when this is surpassed it will return 101 errors with the last one being an "abort" error that you have exceeded the error limit. The Swift code is expecting all errors that return to have source location information and when the "abort" error comes through it causes a precondition failure and the user does not get the useful error logs they should.

To resolve this we need to update the error handling in Swift to properly handle this "abort" error to ensure the user is always receiving the proper error logs to aid in debugging errors.

@BobaFetters BobaFetters added bug Generally incorrect behavior planned-next Slated to be included in the next release labels Jul 18, 2023
@BobaFetters BobaFetters self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Generally incorrect behavior planned-next Slated to be included in the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant