Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into TSAN failures #600

Closed
designatednerd opened this issue Jul 1, 2019 · 3 comments · Fixed by #1549
Closed

Look into TSAN failures #600

designatednerd opened this issue Jul 1, 2019 · 3 comments · Fixed by #1549
Assignees
@hwillson @designatednerd
Labels
bug Generally incorrect behavior threading-sadness
Projects
Developer Experience Improvement
Milestone
0.38.0

Comments

@designatednerd
Copy link
Contributor

In #551 @martijnwalraven tried turning on the Thread Sanitizer, and that's led to some maddeningly inconsistent failures on CI. I was suddenly able to reproduce a bunch of times this morning, but when working with him today, I was not able to reproduce using exactly the same laptop/simulator/code. Martijn can't repro on his end either.

After trying and trying to repro this afternoon, our strong hunch is this is a long-standing problem that's been uncovered by turning on TSAN and not anything to do with his PR. I'm opening this issue to put a pin in it so we can try to figure out what's happening once we've dealt with some more urgent issues.
@designatednerd designatednerd self-assigned this Jul 1, 2019
@designatednerd designatednerd mentioned this issue Jul 2, 2019
Closed
@designatednerd designatednerd added the bug Generally incorrect behavior label Jul 11, 2019
@designatednerd designatednerd mentioned this issue Oct 22, 2019
Merged
@designatednerd
Copy link
Contributor Author

I was making sure TSAN passed for WebSocket at least as part of #853, and now everything's passing TSAN even on SQLite and main libs. So it looks like some other fixes that got in here helped fix this up. I'll close this out once #853 is merged.

@designatednerd
Copy link
Contributor Author

derp, I'm an idiot and only turned it on for the run action, it's still failing like crazy when I turn it on for the test action 🤦‍♀️

@designatednerd designatednerd added this to To Do in Developer Experience Improvement via automation Oct 22, 2019
@designatednerd designatednerd mentioned this issue Oct 24, 2019
Closed
@hwillson hwillson self-assigned this Jul 15, 2020
@designatednerd designatednerd added this to the Next Release milestone Nov 30, 2020
@designatednerd designatednerd linked a pull request Dec 1, 2020 that will close this issue
Turn on thread sanitizer for tests #1549
Merged
@designatednerd
Copy link
Contributor Author

My god, it works now! Closing this out, at last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwillson hwillson

@designatednerd designatednerd

Labels
bug Generally incorrect behavior threading-sadness
Projects
No open projects
Developer Experience Improvement
  
Backlog
Milestone
0.38.0
Development

Successfully merging a pull request may close this issue.

Turn on thread sanitizer for tests apollographql/apollo-ios
2 participants
@hwillson @designatednerd