Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Generation] Need details about external types referenced in typesUsed array #13

Closed
felipecsl opened this issue Dec 5, 2016 · 3 comments

Comments

@felipecsl
Copy link
Contributor

felipecsl commented Dec 5, 2016

From Slack discussion:

felipecsl [12:21 PM]
@martijnwalraven I was looking at the HeroAppearsIn query and the generated IR references the Episode type in the typesUsed array, however its definition can’t be found anywhere in the data. Also I checked the Swift code generated for that query and noticed that it does include a public enum Episode. Sounds like we’re gonna have to add the definition of any external types to the IR so we can generate code based solely on the IR. It sounds like the Swift generator is retrieving that data from somewhere else

@martijnwalraven
Copy link
Contributor

I just published version 0.9.5 of apollo-codegen, which now includes type information as part of typesUsed. Types can be either EnumType or InputObjectType.

@sav007
Copy link
Contributor

sav007 commented Dec 6, 2016

Issue to add support of enum types has been created: #22

@felipecsl
Copy link
Contributor Author

This has been taken care of already. Will create a separate issue for handling InputObjectType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants