Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL schema download asks for --service on android client #2728

Closed
nicusorflorin opened this issue Nov 6, 2020 · 4 comments · Fixed by #2730
Closed

SDL schema download asks for --service on android client #2728

nicusorflorin opened this issue Nov 6, 2020 · 4 comments · Fixed by #2730

Comments

@nicusorflorin
Copy link

Summary
Running * ./gradlew downloadApolloSchema --endpoint https://your.graphql/endpoint --schema src/main/graphql/com/example/schema.sdl * asks for -- service on client android

Version
2.4.2

Description
Ran the command in the terminal and it gave that error, for json it works fine

@nicusorflorin
Copy link
Author

nicusorflorin commented Nov 6, 2020

Doubled checked, it seems it doesn't work for json either. I assume it's version related in this case?
I can confirm it works fine on 2.4.0

@martinbonnin
Copy link
Contributor

Damn, sorry about that, that has been introduced by #2712. Relaxing the variant check introduced this ambiguity.

I'll make a quick fix. In between, you can workaround by adding --service=service (or the name of your service if you explicitely set one):

./gradlew downloadApolloSchema --endpoint https://your.graphql/endpoint --schema src/main/graphql/com/example/schema.sdl --service=service

@nicusorflorin
Copy link
Author

It's ok i downloaded with 2.4.0 and then updated again :D. but i still cannot use SDL schema, added a new bug for that #2729

@martinbonnin
Copy link
Contributor

@nicusorflorin 2.4.3 has been released with a fix for this issue as well as some fixes for SDL string parsing. The string escape/parsing is a bigger story, which I hope to tackle in the coming days but hopefully 2.4.3 is good enough to let you use SDL schema. Let me know how that goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants