Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler plugin API + classloader isolation #5415

Closed
martinbonnin opened this issue Nov 30, 2023 · 0 comments · Fixed by #5604
Closed

Compiler plugin API + classloader isolation #5415

martinbonnin opened this issue Nov 30, 2023 · 0 comments · Fixed by #5604
Assignees

Comments

@martinbonnin
Copy link
Contributor

Description

It's possible to customize the compiler output using one of the many Gradle options. Most of them are simple Strings/Int/Boolean that are easy to serialize and pass through but sometimes, the customization requires code. Two examples are:

  • OperationOutputGenerator
  • CompilerHooks

In those cases, the apollo-gradle-plugin API exposes a version that can be bumped whenever something changes in the implementation. While working, it's a bit cumbersome.

Instead, we could have a configuration that we load in an isolated worker:

dependencies {
  add("apollo${Service}Compiler", project(":apollo-compiler-plugin"))
}

Not only does it remove the version workaround but it promotes the apollo-compiler API to a first-class API and potentially removes some classloading issues (especially around KotlinPoet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant