Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages from com.apollostack to com.apollodata #87

Closed
felipecsl opened this issue Jan 19, 2017 · 7 comments
Closed

Rename packages from com.apollostack to com.apollodata #87

felipecsl opened this issue Jan 19, 2017 · 7 comments

Comments

@felipecsl
Copy link
Contributor

No description provided.

@martijnwalraven
Copy link
Contributor

@felipecsl: Hey sorry, I talked about this internally, and it turns out we're planning on using apollographql for all our open source stuff and reserve apollodata for the commercial services. We already use the Twitter handle and we'll also be renaming the GitHub organization to apollographql.

So I'm afraid I'll have to ask the Sonatype people to change the group ID as well.

@martijnwalraven
Copy link
Contributor

@felipecsl: I think we should be all set! https://issues.sonatype.org/browse/OSSRH-27585

@sav007
Copy link
Contributor

sav007 commented Jan 20, 2017

@martijnwalraven @felipecsl so the final package name is com.apollographql right?

Then we need to rename:

  • com.apollostack.api.graphql -> com.apollographql.api
  • com.apollostack.compiler -> com.apollographql.compiler
  • com.apollostack.converter.pojo -> com.apollographql.converter.pojo ???
  • com.apollostack.android (in apollo-converter/moshi module) -> com.apollographql.converter.moshi ???
  • com.apollostack.android.gradle -> com.apollographql.android.gradle
  • com.apollostack.android (in apollo-runtime) -> com.apollographql.android
  • com.example.apollostack.sample -> com.apollographql.android.sample ???

@martijnwalraven
Copy link
Contributor

@sav007: Yes, or maybe prefix everything with com.apollographql.android (so com.apollographql.android.api for example)?

@felipecsl
Copy link
Contributor Author

Either way sounds good. Thanks for the update Martijn. I'll proceed with the rename after the current open PRs have been merged

@sav007
Copy link
Contributor

sav007 commented Jan 22, 2017

@felipecsl you are good to go with renaming packages all PRs merged

@felipecsl
Copy link
Contributor Author

ok working on this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants