Run v3 integration tests against v4 codegen + runtime #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Dec 1, 2023
Comment on lines
-393
to
+399
| assertResponseListEquals(networkResponses, networkActual) | ||
| assertIs<ApolloCompositeException>(throwable) | ||
| throwable as ApolloCompositeException | ||
| assertIs<ApolloNetworkException>(throwable!!.suppressedExceptions.first()) | ||
| assertIs<CacheMissException>(throwable!!.suppressedExceptions.getOrNull(1)) | ||
| assertEquals("Object 'computers.0.screen' has no field named 'isColor'", throwable!!.suppressedExceptions.getOrNull(1)!!.message) | ||
| assertResponseListEquals(networkResponses, responses.take(2)) | ||
|
|
||
| assertIs<ApolloNetworkException>(responses.get(2).exception) | ||
| responses.get(3).exception.apply { | ||
| assertIs<CacheMissException>(this) | ||
| assertEquals("Object 'computers.0.screen' has no field named 'isColor'", message) | ||
| } |
There was a problem hiding this comment.
That one is interesting. The previous behaviour is not emulated by our toFlowV3 replacement in the @defer case. Here 3.x had a ApolloCompositeException even though there were technically success network responses.
martinbonnin
commented
Dec 1, 2023
| @@ -2,13 +2,13 @@ | |||
| android-plugin = "7.2.1" | |||
| android-plugin-min = "3.4.2" | |||
| android-sdkversion-compile = "31" | |||
| android-sdkversion-min = "15" | |||
| android-sdkversion-min = "16" | |||
There was a problem hiding this comment.
For SQLDelight 2
martinbonnin
commented
Dec 1, 2023
| assertTrue(records.containsKey("""animalById({"id":null})""")) | ||
| assertTrue(records.containsKey("""animalById({"id":0})""")) |
There was a problem hiding this comment.
This is actually the correct behaviour 🎉
query GetAnimalByIdWithDefaultValue($id: ID = 0) {
animalById(id: $id) {
species
}
}
|
Closing this one as it's not meant to be merged. It's there as a reference only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft only to check the places that need updating