Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: output warning if query type generation is suppressed because of naming conflict #1427

Closed
jorroll opened this issue Jul 21, 2019 · 2 comments · Fixed by #1466
Closed
Labels
🐞 bug 🤖 component - codegen related to the codegen core packages ✔ confirmed

Comments

@jorroll
Copy link

jorroll commented Jul 21, 2019

As mentioned in #670, apollo codegen requires query names to be unique for a project when generating types. If two queries have the same name, type generation for the second query will be silently skipped.

This behavior is unexpected. It would be very helpful is apollo codegen output a console warning, including a filepath, whenever this occurs.

@JakeDawkins
Copy link
Contributor

Hey @thefliik, I'd like to see if I can add a warning to this. Can you provide me with a simple reproduction repo that's affected by this to save me some time?

@JakeDawkins JakeDawkins added ✔ confirmed 🐞 bug 🤖 component - codegen related to the codegen core packages labels Aug 6, 2019
@jorroll
Copy link
Author

jorroll commented Aug 7, 2019

@JakeDawkins here you go: https://github.com/thefliik/apollo-tooling-issue

I left some simple reproduction steps in the repo's readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🤖 component - codegen related to the codegen core packages ✔ confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants