Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql 16 renamed PossibleTypeExtensions to PossibleTypeExtensionsRule #2474

Open
jer-sen opened this issue Nov 12, 2021 · 2 comments · May be fixed by #2534
Open

graphql 16 renamed PossibleTypeExtensions to PossibleTypeExtensionsRule #2474

jer-sen opened this issue Nov 12, 2021 · 2 comments · May be fixed by #2534

Comments

@jer-sen
Copy link

jer-sen commented Nov 12, 2021

Hello,

At this line file required should be updated:

apollo-tooling/packages/apollo-graphql/src/schema/buildSchemaFromSDL.ts

Line 57 in 5b0b1ed

const PossibleTypeExtensions: typeof import("graphql/validation/rules/PossibleTypeExtensions").PossibleTypeExtensions = require("graphql/validation/rules/PossibleTypeExtensions")

This was referenced Dec 29, 2021
Closed
Open
@m1heng
Copy link

m1heng commented Dec 29, 2021

PR made, review needed 😝

@m1heng
Copy link

m1heng commented Jan 18, 2022

some attentions needed here @trevor-scheer

@hails hails mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatible logic for graphql@16 m1heng/apollo-tooling
2 participants
@jer-sen @m1heng