Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cleanup (Fed JVM is an officially supported Apollo OSS project) #173

Closed
5 of 10 tasks
hwillson opened this issue May 17, 2022 · 7 comments
Closed
5 of 10 tasks
Assignees

Comments

@hwillson
Copy link
Member

hwillson commented May 17, 2022

This project has had an interesting history; it was originally created to address Apollo's own specific infrastructure needs, but has since grown into a reliable and effective way to work with Federation 1/2 on a JVM. While the library itself has grown, the supporting OSS infrastructure for this project has not, since this project was not staffed as an official Apollo OSS project. This has changed, meaning Federation JVM now has a team behind it. To reflect this, we need to make several changes to this project and repo to bring it up to Apollo OSS standards. We'll use this issue to track the needed changes at a high level, breaking more specific todos out into separate issues.

Things that need to happen:

@setchy
Copy link
Contributor

setchy commented May 17, 2022

Awesome @hwillson. Could I add a +1 for adding a CHANGELOG.md and ROADMAP.md please 🙏

@martinbonnin
Copy link
Contributor

+1 for ROADMAP.md 👍

For CHANGELOG.md, there is RELEASE_NOTES.md, did you want to change the name (I remember something about renovate maybe? 👀 ) ? Or more details in there?

@setchy
Copy link
Contributor

setchy commented May 17, 2022

Ah, my bad @martinbonnin - I overlooked RELEASE_NOTES.md. Renovate can handle this, but perhaps a rename to make it consistent with apollographql/federation, apollographql/apollo-server, apollographql/rover etc wouldn't hurt

@martinbonnin
Copy link
Contributor

a rename to make it consistent with apollographql/federation, apollographql/apollo-server, apollographql/rover etc wouldn't hurt

Works for me 👍

@dariuszkuc
Copy link
Member

dariuszkuc commented May 26, 2022

Instead of using separate RELEASE_NOTES.md/CHANGELOG.md files we will be using standard Github Releases as it will contain the same information.

@hwillson
Copy link
Member Author

hwillson commented Jun 8, 2022

Thanks to @dariuszkuc a lot of this work is now done! 🎉 We'll close this task off, and continue tracking the remaining items in separate issues.

@hwillson hwillson closed this as completed Jun 8, 2022
@setchy
Copy link
Contributor

setchy commented Jun 8, 2022

Yes, huge thank you @dariuszkuc 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants