Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Update Peer Dependencies | React, React DOM #57

Closed
GoPro16 opened this issue Aug 29, 2019 · 1 comment
Closed

Update Peer Dependencies | React, React DOM #57

GoPro16 opened this issue Aug 29, 2019 · 1 comment

Comments

@GoPro16
Copy link
Contributor

GoPro16 commented Aug 29, 2019

I'm probably missing something here but it doesn't look like react or react-dom is included as a dependency here and its magically working.

I was noticing this on my project and figured I would open an issue here as well.
@GoPro16 GoPro16 changed the title Updated Peer Dependencies | React React DOM Update Peer Dependencies | React React DOM Aug 29, 2019
@GoPro16 GoPro16 changed the title Update Peer Dependencies | React React DOM Update Peer Dependencies | React, React DOM Aug 29, 2019
@trevorblades
Copy link
Contributor

Thanks for noticing this! I've added react and react-dom to the themes' peer dependencies in bb5a854

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevorblades @GoPro16