Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql 15 compatibilty #298

Closed
rchl opened this issue May 6, 2020 · 4 comments · Fixed by #299
Closed

graphql 15 compatibilty #298

rchl opened this issue May 6, 2020 · 4 comments · Fixed by #299

Comments

@rchl
Copy link

rchl commented May 6, 2020

Is this package fully compatible with v15 of https://www.npmjs.com/package/graphql?
If yes then peerDependencies should be updated to include it.

@mehmetnyarar
Copy link

Looks like "graphql-tag": "^2.10.3" is not compatible with "graphql": "15.1.0". It throws an error regarding DocumentNode:

Argument of type 'import("./node_modules/graphql-tag/node_modules/graphql/language/ast").DocumentNode' is not assignable to parameter of type 'import("./node_modules/graphql/language/ast").DocumentNode'.
Types of property 'loc' are incompatible

@adieuadieu
Copy link

adieuadieu commented Jun 12, 2020

Also ended up here as I was receiving an error Must provide Source. Received: undefined when combining graphql@15.1.0 with graphql-tag@2.10.3 (specifically, the webpack loader). Not sure if correlation or causation.

@Cito
Copy link

Cito commented Jun 15, 2020

@mehmetnyarar This looks more like an incompatibility between two different versions of graphql.js (the one installed with graphql-tag and the one installed separately), not between graphql-tag and graphql.js. In the new version of graphql.js, the loc is an ES6 class.

@qortex
Copy link

qortex commented Jul 8, 2020

Any update on this guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants