Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid infinite loop when using WrapQuery on second level fields #1008

Merged
merged 3 commits into from Nov 30, 2018
Merged

Avoid infinite loop when using WrapQuery on second level fields #1008

merged 3 commits into from Nov 30, 2018

Conversation

mdlavin
Copy link
Contributor

@mdlavin mdlavin commented Nov 27, 2018

Before the fix provided, the new testcase would get stuck in an infinite loop. The use of unshift was not correct.

Fixes #1007

@mdlavin
Copy link
Contributor Author

mdlavin commented Nov 29, 2018

@benjamn / @hwillson I see that this PR is marked with a warning "This branch is out-of-date with the base branch". Is that something that I need to fix before the PR will be reviewed? I believe the code will merge into master without conflict as it currently is

hwillson
hwillson approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great here @mdlavin - thanks very much!

@hwillson hwillson merged commit 9abc074 into ardatan:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwillson hwillson hwillson approved these changes

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using WrapQuery on a multi-segment path hangs
2 participants
@mdlavin @hwillson