Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user-provided buildSchema options #1154

Merged
merged 4 commits into from
Jun 21, 2019
Merged

Allow user-provided buildSchema options #1154

merged 4 commits into from
Jun 21, 2019

Conversation

trevor-scheer
Copy link
Contributor

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

hwillson
hwillson approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @trevor-scheer - thanks!

@hwillson
Copy link
Contributor

Just noting that the test failures here are not related to this PR. I'll look into getting those fixed separately. Thanks!

@hwillson hwillson merged commit 2e6236e into master Jun 21, 2019
@hwillson hwillson deleted the trevor/flexible-buildSchema-options branch June 21, 2019 00:57
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Jun 30, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
829255e 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Sep 22, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
de528a6 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Sep 22, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
9d1b033 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Sep 22, 2019
@trevor-scheer @yaacovCR
Allow user-provided buildSchema options (ardatan#1154)
4ce0119 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Sep 22, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
aee862d 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Sep 22, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
70d32ee 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Oct 3, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
a0c16de 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Oct 25, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
0466791 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Oct 25, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
def3058 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Nov 4, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
1dac4ba 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
yaacovCR pushed a commit to yaacovCR/graphql-tools-fork that referenced this pull request Dec 31, 2019
@trevor-scheer @yaacovCR
feat(generate): Allow user-provided buildSchema options (ardatan#1154)
c494cf7 
* Allow buildSchema options to be passed in by the user

* Add congruency for printSchema options

* Prettier

* Add tests for new buildSchema options
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwillson hwillson hwillson approved these changes

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trevor-scheer @hwillson