Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small non-breaking refactors #918

Merged
merged 3 commits into from Aug 2, 2018
Merged

Small non-breaking refactors #918

merged 3 commits into from Aug 2, 2018

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Aug 2, 2018

Just working on simplifying some code.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@stubailo stubailo merged commit ddb429d into master Aug 2, 2018
@ardatan ardatan deleted the code-cleanup branch April 2, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant