Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Fetcher interface in docs #933

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

zcei
Copy link
Contributor

@zcei zcei commented Aug 20, 2018

As mentioned in #891, the docs for a custom fetcher are off since a couple of months.

After c91e577 landed, the types were changed to accept a DocumentNode instead of a string.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@ghost ghost added the docs Focuses on documentation changes label Aug 20, 2018
@apollo-cla
Copy link

@zcei: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@zcei zcei force-pushed the docs/adjust-fetcher-interface branch from e7def9c to 35753d3 Compare August 20, 2018 09:11
@ghost ghost added the docs Focuses on documentation changes label Aug 20, 2018
@zcei zcei force-pushed the docs/adjust-fetcher-interface branch from 35753d3 to 094896b Compare August 20, 2018 09:15
@ghost ghost added the docs Focuses on documentation changes label Aug 20, 2018
Copy link

@JosephCarrington JosephCarrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@zcei
Copy link
Contributor Author

zcei commented Aug 31, 2018

@freiksenet maybe? You merged the PR that introduced this behavior as well 😛

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @zcei - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants