Adjust Fetcher interface in docs #933
Merged
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #891, the docs for a custom fetcher are off since a couple of months.
After c91e577 landed, the types were changed to accept a
DocumentNode
instead of astring
.TODO:
If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)Make sure all of the significant new logic is covered by testsMake sure all tests and linter rules pass