Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in enum input -> internal value conversion #974

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

tgriesser
Copy link
Contributor

Fixes the inverse of #973, values on input should be mapped to their internal values. This was broken because of the changes noted here. I took what this was trying to achieve and moved it into a separate transform specific to merged schema delegation. Tests included.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@tgriesser tgriesser changed the title Enum inputs Fix regression in enum input -> internal value conversion Oct 12, 2018
Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @tgriesser - thanks very much!

@hwillson hwillson merged commit d3cbefc into ardatan:master Oct 18, 2018
@hwillson
Copy link
Contributor

Available in graphql-tools 4.0.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants