Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing parsed schema ast to mergeSchemas #977

Merged
merged 5 commits into from
Oct 24, 2018

Conversation

ganemone
Copy link
Contributor

@ganemone ganemone commented Oct 15, 2018

Many APIs across graphql-tools and apollo libraries support passing
a parsed graphql ast or a graphql string. For example, makeExecutableSchema.
This PR updates the mergeSchemas API to support passing a parsed graphql ast.

@ghost ghost added the feature New addition or enhancement to existing solutions label Oct 15, 2018
@apollo-cla
Copy link

@ganemone: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an approval here in case we need to fork this, but hoping we can upstream. Nice!

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @ganemone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants