Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error.message tag on router span for all traces where there is a broken pipe error #4576

Closed
danpayne17 opened this issue Jan 31, 2024 · 0 comments · Fixed by #4770
Closed
Assignees
Labels
potentially-breaking Requires an incompatible change raised by user

Comments

@danpayne17
Copy link

Describe the bug
When the caller closes the connection to the router before it is done sending the response, the trace that is sent to DataDog is missing the error.message tag on the router span. This is causing DataDog to be unable to display the cause of the error

To Reproduce
Steps to reproduce the behavior:

  1. Connect the router to DataDog
  2. Launch router with a single subgraph and in the subgraph, have it wait 10 seconds when it receives the request from the router
  3. Use curl to send a request to the router
  4. While the request is waiting at the subgraph, cancel the curl request (ctrl-c)
  5. Observe the error in DataDog and how there is no error message. Instead it displays "Missing error message and stack trace"
image

Expected behavior
An error message indicating the error encountered (e.g. 'Broken pipe') should be displayed in DataDog and seen in the router trace span at error.message

Router:

  • OS: Amazon Linux 2023
  • Router Version: 1.37.0

Additional context
Other errors (e.g. 400) seem to populate error.message just fine. It's only when there's a broken pipe that it doesn't tag set.

Errors view in DataDog:
image

Span tags (error key excerpted):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potentially-breaking Requires an incompatible change raised by user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants