Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fully disabling response compression #4800

Closed
xuorig opened this issue Mar 13, 2024 · 2 comments
Closed

Allow fully disabling response compression #4800

xuorig opened this issue Mar 13, 2024 · 2 comments

Comments

@xuorig
Copy link
Contributor

xuorig commented Mar 13, 2024

Currently, apollo-router will compress responses by respecting the accept-encoding header. Compression has a cost, and certain contexts may not require compression to happen on the router itself, for example if it is fronted by another process with compression enabled.

A new configuration option could be added so that response compression can be turned completely off. Happy to contribute a PR.

@garypen
Copy link
Contributor

garypen commented Mar 18, 2024

Could you provide a little more detail about the "certain contexts" that you mention?

In the example you provide, wouldn't it be the responsibility of the fronting process to remove/modify the "accept-encoding" header?

@xuorig
Copy link
Contributor Author

xuorig commented Mar 18, 2024

Closing, @garypen you're totally right 👍 it's a problem in itself if the fronting process sends accept-encoding while taking ownership of compression.

@xuorig xuorig closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants