Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover dev should accept a <GRAPH_REF> argument #1494

Open
EverlastingBugstopper opened this issue Jan 30, 2023 · 0 comments
Open

rover dev should accept a <GRAPH_REF> argument #1494

EverlastingBugstopper opened this issue Jan 30, 2023 · 0 comments

Comments

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Jan 30, 2023

Situation

rover dev exists, and requires that you run rover dev once for each individual subgraph.

Problem

Managing multiple terminals quickly gets out of hand, and most times you want to make one small change to one or two subgraphs instead of the whole thing at once. This means that the development story as is becomes cumbersome quickly.

Proposed Solution

If you specify a <GRAPH_REF> along with rover dev, then Rover should "extend" the supergraph that lives in Studio.

Proposed Implementation

Any time a graph ref is passed to rover dev

  1. Check if the graph is federated, if so, fetch all subgraphs (name, url, schema), if not, just fetch the schema and prompt for the name and url
  2. Use the subgraph definitions from the graph ref as a base, and sub in local subgraph definitions as they are supplied by the user
  3. Download internal build plugins as opposed to open source build plugins in order to ensure the composed supergraph schema matches what would be provided in managed federation

Attaching additional rover dev sessions should still work, but we should make sure that specifying the same <GRAPH_REF> in a second command does not fetch all of those subgraphs again if the leader session already has knowledge of them.

Open Questions

You can add more subgraphs by running rover dev more times. Should we require that you can only specify one <GRAPH_REF>? Or should we allow you to dev multiple <GRAPH_REF>s together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant