Es5 #147
Merged
Es5 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DxCx
commented
Sep 14, 2016
•
DxCx
commented
- Update CHANGELOG.md with your change (include reference to issue & this PR)
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
| json: true, | ||
| resolveWithFullResponse: true, | ||
| private getCSRFAndCookieThen(callback: (csrf: string, cookie: string) => any): Promise<any> { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
this should just be return rp({ ... }).then(...)
There was a problem hiding this comment.
not working,
RP is not returning native promises, but Bluebird one,
used this to convert Bluebird to native.
Also, this code will be eliminated soon if i got it right from @helfer
|
Do we need to add typings for es6-promise as well? |
|
Alright, let's ship it! |
|
Thanks for the quick turnaround! |
|
ofcourse :) |
|
Closes #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.