-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for custom scalar client-side usage #224
Conversation
is there someone trying to fix this? |
Can't hurt! Doubt anyone will look at it until California Monday at the
earliest anyway...
…On Dec 11, 2016 12:41 AM, "Hagai Cohen" ***@***.***> wrote:
is there someone trying to fix this?
or i'll give it a go?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABBVFM203VPeHLvn6zwF0RL0UbOLVmyks5rG7cugaJpZM4LHypv>
.
|
Ok, later on, we will run the function to bind resolvers. however, all the arguments of the fields (which has arguments ofcourse) did not replace type. so, to sum this up, we have couple of choices:
if (type instanceof GraphQLScalarType) {
const resolveFn = resolveFunctions[typeName];
if (resolveFn instanceof GraphQLScalarType) {
const thisScalarType: GraphQLScalarType = resolveFn;
schema.getTypeMap()[typeName] = thisScalarType;
}
}
|
@DxCx I'd say we should just replace the functions and not the actual scalar instance. |
(Like your approach 2) |
So literally just delete the quoted block? That does appear to make the whole test suite pass (well, Uri's test actually has to be adjusted slightly to |
@glasser
Fixes #225