This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Don't throw in the server on certain unsub messages #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use an object as a map with arbitrary keys, you should either use `Object.create(null)` or the `Map` class. Otherwise you can run into trouble where keys like `toString` and `constructor` are in your app too. If the server received such a message, an exception would get thrown within SubscriptionManager.unsubscribe.
glasser
force-pushed
the
glasser/safer-unsub
branch
from
86dcc9b
to
ac56986
Compare
|
Thanks @glasser! |
helfer
approved these changes
Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use an object as a map with arbitrary keys, you should either use
Object.create(null)or theMapclass. Otherwise you can run into troublewhere keys like
toStringandconstructorare in your app too. If the serverreceived such a message, an exception would get thrown within
SubscriptionManager.unsubscribe.
Noticed while reviewing @Urigo 's PR