Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"lithostitched:jigsaw" won't place elements correctly #4

Closed
SettingDust opened this issue Feb 3, 2024 · 4 comments
Closed

"lithostitched:jigsaw" won't place elements correctly #4

SettingDust opened this issue Feb 3, 2024 · 4 comments

Comments

@SettingDust
Copy link

I'm on 1.20.1 Fabric

https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/1.20/common/src/main/resources/data/ctov/worldgen/structure/small/village_beach.json

I replaced the "minecraft:jigsaw" to "lithostitched:jigsaw".
The structures in first pic is ctov:village/beach/jobsite/wizard_tower which injected by Lithostitched

lithostitched:jigsaw
图片

minecraft:jigsaw
图片

Disabled the injection and works. Have no idea of the reason.
图片

@SettingDust
Copy link
Author

Interesting after using "lithostitched:guaranteed" for injection.

图片

@SettingDust
Copy link
Author

SettingDust commented Feb 4, 2024

With debugging. The lithostitched$structurePoolElements won't include the templates. There are only the injected pieces.
I found the reason here set it https://github.com/Apollounknowndev/lithostitched/blob/1.20.1/common/src/main/java/dev/worldgen/lithostitched/worldgen/modifier/AddTemplatePoolElementsModifier.java#L90
Is it intended? I think the original one should be iterated here instead of the elements()
图片

@SettingDust
Copy link
Author

It's fine :D
图片

@Apollounknowndev
Copy link
Owner

Fixed in 1.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants