Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ is not highlighted #49

Closed
tiye opened this issue May 21, 2013 · 9 comments
Closed

@ is not highlighted #49

tiye opened this issue May 21, 2013 · 9 comments

Comments

@tiye
Copy link

tiye commented May 21, 2013

Attributes and methods of a class are different,
I think it's better to highlight the @ to make it striking.

@aponxi
Copy link
Collaborator

aponxi commented Jun 1, 2013

sustained/CoffeeScript-Sublime-Plugin#27 got the fix from there

@aponxi aponxi closed this as completed in 9638f54 Jun 1, 2013
@tiye
Copy link
Author

tiye commented Jun 1, 2013

I found there's an upgrade on Sublime, but I didn't see any change after upgrading.
Like this:

f = ->
  console.log @a

I suppose it couldn't be that quick.. How can I check the fixed version?

@aponxi
Copy link
Collaborator

aponxi commented Jun 1, 2013

Maybe I misunderstood you. I don't know what it was like before but right now what I see is this image below. How do you want it to be like?

@aponxi aponxi reopened this Jun 1, 2013
@aponxi
Copy link
Collaborator

aponxi commented Jun 1, 2013

Also two questions:

  1. Are you on Sublime Text 3?
  2. Are you using version 0.7?

@tiye
Copy link
Author

tiye commented Jun 1, 2013

Sublime Text version: 2.0.1 Build 2217
I found there's a package.json file in the Sublime Package I installed.
Seems it's the latest version.. But, looks strange here.
I did removed the CoffeeScript Package and installed BetterCoffeeScript here,
but my highlights looks really different from yours:
screenshot from 2013-06-01 21 49 14

@aponxi
Copy link
Collaborator

aponxi commented Jun 1, 2013

I use pastels on dark color scheme, it is exactly the same as yours when I use the default scheme (monokai)


The code is this:

jsdom = require "jsdom"
fs = require("fs");
html = fs.readFileSync("./test_subjects/chrome_bookmark.html").toString();
# RESULTS = new Array()

jsdom.env
  html: html
  scripts: ["./req/jquery.min.js"]
  done: (errors, window) ->
    $ = window.$
    itemdoubleclick = ""
    results = new Array()
    # console.log $("html").html()
    anchors = $("dl").find("a")
    #console.log $
    #
   class Box2DUtility
    constructor: (s) -> @s = s
    m: () -> alert "instance method called: #{@s}"
    @drawWorld: (s) -> new @ s

  Box2DUtility.drawWorld('pancakes').m()


    # console.log(anchors);
    anchors.each (i, e) ->
      url = $(e).attr("href")
      name = $(e).text()
      add_date = $(e).attr("add_date")
      tags = new Array()
      # console.dir $(e).attr("href")
      $(e).parents("dl").each (ii, ee) ->
        folder = $(ee).prev()
        # console.dir folder.text()
        tag = folder.text()
        tags.push tag

      result =
        url: url
        name: name
        add_date: add_date
        tags: tags

      results.push result
    RESULTS = results;
    console.dir results

# console.log RESULTS

@tiye
Copy link
Author

tiye commented Jun 1, 2013

Oh. much better with Pastel Dark Theme now. Thanks.
https://github.com/jdiehl/dark-pastel
So it's the problem the Monokai Theme introduced..

May I asked what font you are using in Sublime Text. It looks slightly clearer than Monaco on my screen.

@aponxi
Copy link
Collaborator

aponxi commented Jun 2, 2013

Monospace is what I use. By the way Twilight is my favorite color scheme. Be sure to try it out!

@aponxi aponxi closed this as completed Jun 2, 2013
@tiye
Copy link
Author

tiye commented Jun 2, 2013

@aponxi Yeah, Twilight is much cooler than Monokai, I'm switching to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants