Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug how we got clientip #49

Closed
wants to merge 2 commits into from
Closed

Debug how we got clientip #49

wants to merge 2 commits into from

Conversation

satyamsi
Copy link

No description provided.

@sooryamanian91
Copy link

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "proxy-protocol",
    "component": "backend",
    "pr-id": "520",
    "commit-sha": "cfaa3515c6c416ff29cce2bf2421653d6417f4e0"
  },
  {
    "project": "proxy-protocol",
    "component": "elemental",
    "pr-id": "49",
    "commit-sha": "f44d1f977daa63487ed352835704711c88fa0955"
  }
]

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #49 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   97.12%   97.13%   +0.01%     
==========================================
  Files          18       18              
  Lines        1741     1748       +7     
==========================================
+ Hits         1691     1698       +7     
  Misses         28       28              
  Partials       22       22
Impacted Files Coverage Δ
request.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3744f...f44d1f9. Read the comment docs.

@sooryamanian91
Copy link

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "proxy-protocol",
    "component": "backend",
    "pr-id": "520",
    "commit-sha": "cd7ad6962431f6e523a04426b8697a7d8ece0f2b"
  },
  {
    "project": "proxy-protocol",
    "component": "elemental",
    "pr-id": "49",
    "commit-sha": "f44d1f977daa63487ed352835704711c88fa0955"
  }
]

Copy link
Contributor

@primalmotion primalmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch must not go in

@sooryamanian91
Copy link

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "proxy-protocol",
    "component": "backend",
    "pr-id": "520",
    "commit-sha": "e4c1bcaee1991f061a5d2e5597ed514cba6e8597"
  },
  {
    "project": "proxy-protocol",
    "component": "elemental",
    "pr-id": "49",
    "commit-sha": "f44d1f977daa63487ed352835704711c88fa0955"
  }
]

@sooryamanian91
Copy link

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "proxy-protocol",
    "component": "backend",
    "pr-id": "520",
    "commit-sha": "e0a7b080b7cd5fbacbc5150cd72f1f7d3871424f"
  },
  {
    "project": "proxy-protocol",
    "component": "elemental",
    "pr-id": "49",
    "commit-sha": "f44d1f977daa63487ed352835704711c88fa0955"
  }
]

@sooryamanian91
Copy link

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "proxy-protocol",
    "component": "backend",
    "pr-id": "520",
    "commit-sha": "9d9cce5761e3a3d5806e4df8c803d01c538f5039"
  },
  {
    "project": "proxy-protocol",
    "component": "elemental",
    "pr-id": "49",
    "commit-sha": "f44d1f977daa63487ed352835704711c88fa0955"
  }
]

@satyamsi satyamsi closed this Aug 24, 2019
@satyamsi satyamsi deleted the debug branch August 24, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants