Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: enforcerlog #403

Open
wants to merge 8 commits into
base: master
from

Conversation

@sibicramesh
Copy link
Member

commented Sep 6, 2019

No description provided.

sibicramesh added 4 commits Sep 5, 2019
@primalmotion
Copy link
Member

left a comment

also missing to plug that in root.spec

specs/enforcer.spec Outdated Show resolved Hide resolved
@@ -140,6 +142,7 @@ attributes:
type: time
exposed: true
stored: true
deprecated: true

This comment has been minimized.

Copy link
@primalmotion

primalmotion Sep 6, 2019

Member

This is not deprecated. This is where enforcer reports its version

This comment has been minimized.

Copy link
@sibicramesh

sibicramesh Sep 12, 2019

Author Member

This is where it reports the version currentVersion. The lastCollectionTime is useless. This is same as createTime in the enforcerlog now.

specs/enforcerinfo.spec Outdated Show resolved Hide resolved
specs/enforcerinfo.spec Outdated Show resolved Hide resolved
specs/enforcerinfo.spec Outdated Show resolved Hide resolved
specs/enforcerinfo.spec Outdated Show resolved Hide resolved
specs/enforcerinfo.spec Outdated Show resolved Hide resolved
specs/enforcerinfo.spec Outdated Show resolved Hide resolved
package: squall
group: core/enforcer
description: Post a new enforcer information.

This comment has been minimized.

Copy link
@primalmotion

primalmotion Sep 6, 2019

Member

missing internal methods

get:
    description: Retrieves the ...

This comment has been minimized.

Copy link
@sibicramesh

sibicramesh Sep 12, 2019

Author Member

I added get and delete. I don't think we need update here ?

sibicramesh added 2 commits Sep 12, 2019

@sibicramesh sibicramesh changed the title new: enforcerinfo new: enforcerlog Sep 12, 2019

@sibicramesh sibicramesh requested review from primalmotion and satyamsi Sep 12, 2019

sibicramesh added 2 commits Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.