Fixed: remove race around bodyCloser when no content (#100)

PaloAltoNetworks · Aug 12, 2019 · 6ac761d · 6ac761d
1 parent 5a93585
commit 6ac761d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/maniphttp/manipulator.go b/maniphttp/manipulator.go
@@ -739,7 +739,13 @@ func (s *httpManipulator) send(
 
 		// If we have content, we return the response.
 		// The body will be drained by the defered call to closeCurrentBody().
-		if response.StatusCode == http.StatusNoContent || response.ContentLength == 0 || dest == nil {
+		if response.StatusCode == http.StatusNoContent || response.ContentLength == 0 {
+			bodyCloser = nil
+
+			return response, nil
+		}
+
+		if dest == nil {
 			return response, nil
 		}