Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in vortex subscriber when there is no filter #97

Merged
merged 1 commit into from Aug 10, 2019

Conversation

dstiliadis
Copy link
Contributor

Fixes the crash in vortex manipulator where it was assuming that the filter is always not nil.

@ghost
Copy link

ghost commented Aug 9, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "97",
    "commit-sha": "f1a84800e971e16b454bef6650fc34a90fb37140"
  }
]

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #97 into master will decrease coverage by 0.05%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   76.81%   76.76%   -0.06%     
==========================================
  Files          35       35              
  Lines        2566     2569       +3     
==========================================
+ Hits         1971     1972       +1     
- Misses        517      519       +2     
  Partials       78       78
Impacted Files Coverage Δ
manipvortex/manipulator.go 69.37% <25%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d9765...f1a8480. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant