Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a default value of interval prop in DynamicRangeSlider #45

Closed
siddharthlatest opened this issue Apr 24, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@siddharthlatest
Copy link
Member

By default, the interval prop (for the number of histogram bars) should be set to Math.ceil((range.end - range.start) / 10). We already do this in RangeSlider component https://github.com/appbaseio/reactivebase/blob/dev/app/sensors/RangeSlider.js#L243.

@farhan687
Copy link

Range value is not predefined over here.
Here we execute histogram aggregation query to find the range.

In RangeSlider we already have the range values in prop so, this implementation is possible there only.

@farhan687
Copy link

Fixed here: 49c69ac

  • Now we are executing 2 aggregation
  1. Get range values
  2. Execute histogram aggregation query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants