Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to build with SDK 9.2.0 #60

Merged
merged 3 commits into from Sep 16, 2020
Merged

build: update to build with SDK 9.2.0 #60

merged 3 commits into from Sep 16, 2020

Conversation

ewanharris
Copy link
Contributor

Patches the sqlite3.c file to include a fix for compiling on mac catalyst that has not landed in a released version yet

Patches the sqlite3.c file to include a fix for compiling on mac catalyst that has not landed in a released version yet
@build
Copy link

build commented Sep 16, 2020

Warnings
⚠️ SDK version declared in Jenkinsfile (9.2.0.v20200914072649) does not match iOS' titanium.xcconfig value (9.2.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 4 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against ae2c9e5

ios/titanium.xcconfig Outdated Show resolved Hide resolved
@@ -1,6 +1,6 @@
{
"name": "@titanium-sdk/appcelerator.encrypteddatabase",
"version": "4.2.0",
"version": "5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't bump manually, use command line so that the lock file gets bumped too:

npm --no-git-tag-version version major

ewanharris and others added 2 commits September 16, 2020 15:45
Co-authored-by: Christopher Williams <chris.a.williams@gmail.com>
@ewanharris
Copy link
Contributor Author

@sgtcoolguy fixed both of those!

@sgtcoolguy sgtcoolguy merged commit fa53fb7 into master Sep 16, 2020
@sgtcoolguy sgtcoolguy deleted the TIMOB-28124 branch September 16, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants