New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-19794] Android: Recompile with NDK r11c #31
Conversation
appcelerator.https-titanium-2.0.0.zip Binary attached for testing purposes. |
version: 1.1.3 | ||
apiversion: 2 | ||
version: 2.0.0 | ||
apiversion: 3 | ||
architectures: armeabi armeabi-v7a x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
armeabi should be removed. V8 doesn't officially support older variants of ARM like this (they support armeabi-v7a).
Need to also update the .travis.yml to make sure it builds against Xcode 7.3.1 NDK r11c, latest SDK/V8: https://github.com/sgtcoolguy/ti.geofence/blob/d843062df0d056fb569ab3d3ebb05abf2ecf3308/.travis.yml |
Comments addressed. |
This is one of those modules that can have both iOS and Android packaged together. As such, I'm gonna bump the iOS as well. Also, I'm just gonna rebase/squash the commits cause it's getting messy for the purpose of this simple PR. |
https://jira.appcelerator.org/browse/TIMOB-19794 PR is for recompiling the module with NDK r11c along with SDK 6.0.0 that has the latest V8 library. 馃帀
@sgtcoolguy |
I believe it's compiling correctly but I seem not to be able to test/use any "apiversion: 3". Perhaps I'm missing something. |
Refer to tidev/ti.geofence#34 (comment) for more comments. |
Got it working. Seems that the fault lies with Appcelerator Studio. Will be creating a issue ticket for that. Creating a project from cmd line |
appcelerator.https-titanium-2.0.0.zip |
gave me a hard crash:
|
For the record, I get the exact same error using 1.1.3 of the module on 5.3.1 GA of the SDK:
So it looks like the module or it's example code has been broken... |
Looking into the history of the android module and the example code, I'm 99.99% certain that no one ever actually tried running the code for Android. ARGH! So my guess is that it has always and forever been broken. |
This seems bad. Will need to look into this. |
@ashcoding I fixed the issue in a follow-on PR on top of yours: #32 |
https://jira.appcelerator.org/browse/TIMOB-19794
PR is for recompiling the module with NDK r11c along with SDK 6.0.0 that
has the latest V8 library. 馃帀