[TIMOB-23589] Android: Recompile appcelerator.https module against latest SDK #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test SDK - Bump minsdk, apiversion, version - Update travis build - Update wellsfargo SSL cert - Fix Android implementation
sgtcoolguy
changed the title
|
ping @ashcoding @cheekiatng |
|
Code reviewed. Functionally tested. Works like magic. 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @ashcoding 's PR #31
This updates to compile against NDK r11c, and Titanium SDK 6.0.0+.
But it also will include fixes for the Android module. It appears that this platform was never actually tested and never worked properly...
Specifically, the arguments to appcelerator.https. createX509CertificatePinningSecurityManager() were never correct. We take in an Object[] of Object[], not a HashMap[]. I also updated the wellsfargo SSL cert and did some testing with a lot of debug logging to ensure it works as expected.