[TIMOB-24473] Android: Maintain API parity with iOS

[garymathews]

• Deprecate testing and publisherId
• Implement adUnitId and adType
• Use property variables in processProperties
• Bump version to 4.1.0

TEST CASE

var win = Ti.UI.createWindow({backgroundColor: 'gray'}),
    admob = require('ti.admob'),
    view = admob.createView({
        top: 0,
        adBackgroundColor: 'red',
        adType : admob.AD_TYPE_BANNER,
        adUnitId : 'ca-app-pub-3283366778120745/7674974318'
    });

// test deprecation warning
view.setPublisherId('null');

win.add(view);
win.open();

JIRA Ticket

[hansemannn]

@garymathews Is this ready to merge? I wanted to take a look if https://jira.appcelerator.org/browse/TIMOB-24550 is easy to implement.

[garymathews]

@hansemannn Already part of this PR, set adType to AD_TYPE_INTERSTITIAL

[hansemannn]

Can you check with https://github.com/appcelerator-modules/ti.admob/pull/69/files and close mine instead? Wondering because I used an com.google.android.gms.ads.InterstitialAd instance, you specified a FLUID size.

[garymathews]

Android doesn't have that: https://developers.google.com/android/reference/com/google/android/gms/ads/AdSize

AdSize.FLUID was the closest I could get

[hansemannn]

From what I understood, InterstitialAd is no size but a whole different type of ad. The above is the package-resolved class-name.

[Astrovic]

any news about this merge?

[ottopic]

Hello,
any news about Interstitial integration? Is this thread dead?

Thank you

[Astrovic]

On Android you can use this: https://github.com/Astrovic/titanium-admob/

[ottopic]

@Astrovic thank you.
I'll try to use both libraries to obtain the same result in iOS and Android.

[ottopic]

@ypbnv your push is a wonderfull news! I cannot wait to make test with this update! :) :D

[ypbnv]

I have reworked the support for Interstitial ads a little bit - now it is a separate proxy with its own methods and shares events with the AdView. You can check out the documentation and the sample app.

The parity part of the PR is unchanged.

PS. The module version also got bumped to 4.4.0.

@garymathews If you can review the changes it will be awesome.

[garymathews]

CR: PASS

[adampax]

FYI I received the following error when attempting to run Android interstitial on an older project that didn't have run on main in thread enabled.

[ERROR] TiExceptionHandler: (main) [2006,14777] /index.js:126
[ERROR] TiExceptionHandler:     interstitialAd.load();
[ERROR] TiExceptionHandler:                 ^
[ERROR] TiExceptionHandler: Error: setAdListener must be called on the main UI thread.

Fix is to set this in tiapp.xml:
<property name="run-on-main-thread" type="bool">true</property>

Tested on 7.4.1.GA

[ypbnv]

@adampax Thank you for the feedback! You can check the status of the fix here:
https://jira.appcelerator.org/browse/MOD-2479

[adampax]

You're welcome, and thanks @ypbnv for adding the android interstitials 👍