Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #134

Merged
merged 9 commits into from Sep 22, 2020
Merged

Mac support #134

merged 9 commits into from Sep 22, 2020

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Sep 15, 2020

Requires a master/9_2_X build of the SDK after tidev/titanium-sdk#12092 is merged.

This is a work in progress. Looks like we may need to build the underlying zing-objc into xcframeworks including maccatalyst ourselves, since Carthage does not support xcframeworks (or catalyst) yet.

References:

@build
Copy link

build commented Sep 15, 2020

Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 146 tests are passing.

Generated by 🚫 dangerJS against 05fdbe6

@sgtcoolguy
Copy link
Contributor Author

This is failing to build as a result of https://jira.appcelerator.org/browse/TIMOB-27986

We need to add support for picking up xcframeworks in the platform folder.

@sgtcoolguy sgtcoolguy marked this pull request as ready for review September 22, 2020 17:38
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed!

@sgtcoolguy sgtcoolguy merged commit af8eb6e into tidev:master Sep 22, 2020
@sgtcoolguy sgtcoolguy deleted the mac-support branch September 22, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants