Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): add "android:exported" to activities for Android 12 #284

Merged
merged 2 commits into from Sep 1, 2021
Merged

chore(android): add "android:exported" to activities for Android 12 #284

merged 2 commits into from Sep 1, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28479

Summary:

  • Added "android:exported" to all activities that have intent-filters.
    • Needed to compile with API Level 31 (Android 12) or else a build failure will occur.
  • Updated module version to 6.0.1.

@build
Copy link

build commented Jul 17, 2021

Messages
📖 🎉 - congrats on your new release
📖

✅ All tests are passing
Nice one! All 146 tests are passing.
📖

💾 Here are the artifacts produced:

Generated by 🚫 dangerJS against 5beaee5

garymathews
garymathews approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@lokeshchdhry lokeshchdhry merged commit d2eb10c into tidev:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @lokeshchdhry @garymathews