Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIgrate to gradle build system. #22

Merged
merged 34 commits into from Feb 6, 2020
Merged

MIgrate to gradle build system. #22

merged 34 commits into from Feb 6, 2020

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Jan 29, 2020 •
edited by jquick-axway

jquick-axway
jquick-axway approved these changes Jan 29, 2020
View reviewed changes
Copy link

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
style(android): add .clang-format for android
5666128
@sgtcoolguy
style(js): add eslint config
9671700
@sgtcoolguy
chore: update .gitignore
22ba574
@sgtcoolguy
chore(package): add initial package.json
f1e9329
@sgtcoolguy
chore(package): update lockfile
7d504dc
@sgtcoolguy
style(android): fix formatting
f0460af
@sgtcoolguy
style(ios): fix formatting
4d128e6
@sgtcoolguy
chore: move example code to top-level
dd73cc3
@sgtcoolguy
style(js): fix eslint issues on test code
7727eaf
@sgtcoolguy
build(ios): enable modules in xcode project, should fix SDK 8+ build
9f3493a
@sgtcoolguy
build(ios): fix building on sdk 8+
ee6bcab
@sgtcoolguy
docs: add initial apidocs
a81fb33
@sgtcoolguy
style(docs): update whitelisted types for doc validation
64d18e5
@sgtcoolguy
ci(danger): add danger.js
2fe6c29
@sgtcoolguy
ci(jenkins): publish to npm on master branch
a96616f
@sgtcoolguy
fix(android): override apiName
c9b930a
@sgtcoolguy
fix(ios): override apiName
3fc3b9b
@sgtcoolguy
test: add very simple initial test suite
598d099
@build
Copy link

build commented Feb 5, 2020 •
edited

Messages
📖

💾 Here are the artifacts produced:
📖

✅ All tests are passing
Nice one! All 12 tests are passing.

Generated by 🚫 dangerJS against 86207ad

@ssjsamir ssjsamir self-requested a review February 6, 2020 12:51
ssjsamir
ssjsamir approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed able to build module and run example within the module.

Test Environment

MacOS Catalina: 10.15.1 beta
Xcode: 11.3
Java Version: 1.8.0_131
Android NDK: 18.1.5063045
Node.js: 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
Pixel xl (7.1.1) Emulator

@ssjsamir ssjsamir merged commit 1c24a44 into tidev:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ypbnv @build @ssjsamir @jquick-axway @sgtcoolguy @garymathews