Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #128

Merged
merged 10 commits into from Sep 22, 2020
Merged

Mac support #128

merged 10 commits into from Sep 22, 2020

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Sep 14, 2020

JIRA: https://jira.appcelerator.org/browse/TIMOB-28124

Description

  • Builds with the latest 9_2_X SDK build so that macOS support is not compiled
  • Updates iOS to Facebook iOS SDK 7.1.1 (from 6.0.0)
  • Updates Android to Facebook Android SDK 7.1.0 (from 5.13.0)
  • Bumps module versions/npm package versions to reflect major revs of Facebook sdk

@sgtcoolguy
Copy link
Contributor Author

Note that this breaks when we "archive" for macOS due to the underlying frameworks not supporting macOS.

@build
Copy link

build commented Sep 14, 2020

Warnings
⚠️ SDK version declared in Jenkinsfile (9.2.0.v20200922085315) does not match iOS' titanium.xcconfig value (9.2.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 174 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against 6a4ffe5

@sgtcoolguy
Copy link
Contributor Author

Note that #127 doesn't "fix" the macOS support either. So we need to either find a way so native module can explicitly exclude macOS support - or we need to see if we can rebuild the FB frameworks from source with macOS support?

@vijaysingh-axway
Copy link
Contributor

@sgtcoolguy I think -

  1. While building module, make mac build optional. If build get failed for mac, just log message and proceed to create xcframework with device and simulator build.
  2. Most of the third party frameworks are not supporting simulator 'arm64' yet. So building modules with third party framework will also fail with Xcode 12. As only way to support simulator 'arm64' is to create XCFramework, so in any module if platform folder has ".framework" file, exclude simulator 'arm64' and build.

@hansemannn
Copy link
Contributor

hansemannn commented Sep 17, 2020

See facebook/facebook-ios-sdk#1381 for the macOS target at Facebook. I don't think this needs to be merged until Facebook isn't ready.

@sgtcoolguy sgtcoolguy marked this pull request as ready for review September 22, 2020 17:44
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants