Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Move from manual framework integration to Swift Package Manager (SPM) #192

Closed
wants to merge 7 commits into from

Conversation

hansemannn
Copy link
Contributor

This was the easy part. The tricky part will be how to pull these dependencies into the generated project.

The solution could be to package the whole module project and do not attempt to generate a module library at all. That's basically was SPM does as well. Xcode will handle the framework caching in the DerivedData directory and Titanium "just" embeds each module project into the main project.

An alternative could be that Titanium maintains an own config file for it's iOS dependencies, but that would (again) introduce an additional overhead to be handled manually.

@hansemannn hansemannn marked this pull request as draft December 20, 2020 09:59
@build
Copy link

build commented Dec 20, 2020

Fails
🚫 version bump was Major in ios/manifest but None in package.json
Warnings
⚠️ SDK version declared in Jenkinsfile (9.2.0.v20200922085315) does not match iOS' titanium.xcconfig value (9.3.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 94 tests are passing.

Generated by 🚫 dangerJS against 307609a

@hansemannn
Copy link
Contributor Author

Seems like this is not of interest for the team. Closing.

@hansemannn hansemannn closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants