New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0 #29
Conversation
@@ -115,6 +114,16 @@ properties: | |||
description: | | |||
This property must be set before rendering the button. | |||
type: String | |||
deprecated: | |||
since: 5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the "removed: 5.0.0" line here, as it says it is removed in the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hasn't been removed. just deprecated. will be removed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. I'll remove it now since it's a major version bump.
Will capitalise facebook to Facebook |
@cheekiatng When does the user need to call fb.initialize() after require'ing the module? In the README.md, it is used sometimes and sometimes not. Also getting this error when trying to read the user's group
And: When I try to use the like button from the simulator (with web auth), I get this one: |
fb.initialize() is required to be called at least once in an app, before anything in the fb module can be used. |
Thanks for clarifying that! |
FT and CR passed, PR approved. Thank you @cheekiatng ! |
[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0
As it is indicated here: tidev/titanium-sdk#7292 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-19383