Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0 #29

Merged
merged 8 commits into from Oct 13, 2015

Conversation

cheekiatng
Copy link
Contributor

@@ -115,6 +114,16 @@ properties:
description: |
This property must be set before rendering the button.
type: String
deprecated:
since: 5.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the "removed: 5.0.0" line here, as it says it is removed in the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasn't been removed. just deprecated. will be removed later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I'll remove it now since it's a major version bump.

@cheekiatng
Copy link
Contributor Author

Will capitalise facebook to Facebook

@hansemannn
Copy link
Contributor

@cheekiatng When does the user need to call fb.initialize() after require'ing the module? In the README.md, it is used sometimes and sometimes not.

Also getting this error when trying to read the user's group fb.requestWithGraphPath('me/groups', {}, 'GET', function(r){})

FBSDKLog: starting with Graph API v2.4, GET requests for /me/groups should contain an explicit "fields" parameter

And: When I try to use the like button from the simulator (with web auth), I get this one: Presenting view controllers on detached view controllers is discouraged <TiViewController: 0x7fb141775860>.

@cheekiatng
Copy link
Contributor Author

fb.initialize() is required to be called at least once in an app, before anything in the fb module can be used.
The second error implies that there was an issue with the Graph API Request. That, we have to check out Facebook what's the new requirements for this request, i'm guessing it's exactly what it's saying, it needs a "fields" parameter.
3rd part has nothing to do with the module. it's the way Kitchensink was coded.

@hansemannn
Copy link
Contributor

Thanks for clarifying that!

@hansemannn
Copy link
Contributor

FT and CR passed, PR approved. Thank you @cheekiatng !

hansemannn added a commit that referenced this pull request Oct 13, 2015
[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0
@hansemannn hansemannn merged commit 1850852 into tidev:master Oct 13, 2015
@bogdansmc
Copy link

As it is indicated here: tidev/titanium-sdk#7292
This module doesn't work and crash app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants