Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD-2241] Support "statuschange" event on LikeButton #52

Closed
wants to merge 9 commits into from
Closed

[MOD-2241] Support "statuschange" event on LikeButton #52

wants to merge 9 commits into from

Conversation

hansemannn
Copy link
Contributor

andreasanta and others added 6 commits April 26, 2016 17:41
@andreasanta @hansemannn
[ios] Fire event when like status changes
a275084 
Allows to detect when the like status of the native like button
changes, by firing the “statuschanged” event.

# Conflicts:
#	ios/Classes/FacebookLikeButton.m
@andreasanta @hansemannn
* Fires statuschanged event when detects like button changes
2bd18f5 
# Conflicts:
#	android/src/facebook/LikeButtonView.java
@hansemannn
[MOD-2241] Cleanup & refactoring
5cd6edd 
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>
@hansemannn
Bump versiosn, fix Android build
f3574d1 
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>
@hansemannn
[MOD-2241] Set indentation
e1793de 
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>
@hansemannn
[MOD-2241] Improve docs
dfc9a1b
@hansemannn
Copy link
Contributor Author

hansemannn commented Apr 27, 2016 •
edited

EDIT Looks like his facebook app configuration was incorrect, he will take a look! 🚀

@andreasanta, the Android builds throws the following error (detected by @AngelkPetkov):

[ERROR] :  TiBaseActivity: (main) [0,1] Error dispatching lifecycle event: Both context and applicationId must be non-null
[ERROR] :  TiBaseActivity: java.lang.IllegalArgumentException: Both context and applicationId must be non-null
[ERROR] :  TiBaseActivity:     at com.facebook.appevents.AppEventsLogger.activateApp(AppEventsLogger.java:281)
[ERROR] :  TiBaseActivity:     at com.facebook.appevents.AppEventsLogger.activateApp(AppEventsLogger.java:268)
[ERROR] :  TiBaseActivity:     at facebook.TiFacebookModule.onResume(TiFacebookModule.java:130)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiLifecycle.fireLifecycleEvent(TiLifecycle.java:150)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiBaseActivity.onResume(TiBaseActivity.java:1308)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiLaunchActivity.onResume(TiLaunchActivity.java:389)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiRootActivity.onResume(TiRootActivity.java:114)
[ERROR] :  TiBaseActivity:     at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1258)
[ERROR] :  TiBaseActivity:     at android.app.Activity.performResume(Activity.java:6327)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3092)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2481)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.-wrap11(ActivityThread.java)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1344)
[ERROR] :  TiBaseActivity:     at android.os.Handler.dispatchMessage(Handler.java:102)
[ERROR] :  TiBaseActivity:     at android.os.Looper.loop(Looper.java:148)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.main(ActivityThread.java:5417)
[ERROR] :  TiBaseActivity:     at java.lang.reflect.Method.invoke(Native Method)
[INFO] :   ity:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
[ERROR] :  TiBaseActivity:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
[ERROR] :  TiBaseActivity: (main) [0,64] Error dispatching lifecycle event: Both context and applicationId must be non-null
[ERROR] :  TiBaseActivity: java.lang.IllegalArgumentException: Both context and applicationId must be non-null
[ERROR] :  TiBaseActivity:     at com.facebook.appevents.AppEventsLogger.deactivateApp(AppEventsLogger.java:335)
[ERROR] :  TiBaseActivity:     at com.facebook.appevents.AppEventsLogger.deactivateApp(AppEventsLogger.java:322)
[ERROR] :  TiBaseActivity:     at facebook.TiFacebookModule.onPause(TiFacebookModule.java:137)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiLifecycle.fireLifecycleEvent(TiLifecycle.java:151)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiBaseActivity.onPause(TiBaseActivity.java:1254)
[ERROR] :  TiBaseActivity:     at org.appcelerator.titanium.TiLaunchActivity.onPause(TiLaunchActivity.java:337)
[ERROR] :  TiBaseActivity:     at android.app.Activity.performPause(Activity.java:6363)
[ERROR] :  TiBaseActivity:     at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1311)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3367)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3340)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3315)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.-wrap13(ActivityThread.java)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1355)
[ERROR] :  TiBaseActivity:     at android.os.Handler.dispatchMessage(Handler.java:102)
[ERROR] :  TiBaseActivity:     at android.os.Looper.loop(Looper.java:148)
[ERROR] :  TiBaseActivity:     at android.app.ActivityThread.main(ActivityThread.java:5417)
[ERROR] :  TiBaseActivity:     at java.lang.reflect.Method.invoke(Native Method)
[ERROR] :  TiBaseActivity:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
[ERROR] :  TiBaseActivity:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

@hansemannn
Copy link
Contributor Author

@andreasanta Can you check that again, please?

@hansemannn
Merge branch 'master' of github.com:appcelerator-modules/ti.facebook …
8973238 
…into MOD-2241

# Conflicts:
#	android/documentation/changelog.md
#	documentation/changelog.md
@hansemannn
Merge branch 'master' of github.com:appcelerator-modules/ti.facebook …
b0b65c7 
…into MOD-2241
@hansemannn
Copy link
Contributor Author

@andreasanta Last ping, will you be able to check the issues? Otherwise we will close this PR as non-resolved. But I personally really want this in, thank you!

@hansemannn hansemannn closed this Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansemannn @andreasanta