[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project #85

hansemannn · 2017-03-18T10:10:51Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-24593

Android: facebook-android-6.3.0.zip
iOS: facebook-iphone-5.5.0.zip

…into update-android-fb-sdk

…book into update-android-fb-sdk

hansemannn · 2017-06-21T13:55:56Z

@garymathews I finished moving the "old" jar-library to our new AAR-handling and updated to the latest FB-SDK. We would probably need to bump the minimum version of Ti.Facebook to 6.1.0 then, is that okay?

garymathews · 2017-06-21T17:05:09Z

@hansemannn Yes, the older module can be used if pre-6.1.0 compatibility is needed 👍

I'll review this very soon.

garymathews

CR: PASS

vijaysingh-axway · 2017-07-20T07:18:55Z

ios/Classes/FacebookModule.m

+
+        if (description != nil) {
+            NSLog(@"Ti.Facebook.presentMessengerDialog.description has been deprecated in Ti.Facebook 5.5.0 as of the Graph v2.9 changes.");
+            content.contentDescription = [params objectForKey:@"description"];


As per FBSDKShareLinkContent.h -
@Property (nonatomic, readonly) NSString *contentDescription
DEPRECATED_MSG_ATTRIBUTE("contentDescription is deprecated from Graph API 2.9");

contentDescription has changed to read only, but you are assigning to it. It is giving build error. Please remove it.

vijaysingh-axway · 2017-07-20T07:19:43Z

ios/Classes/FacebookModule.m

+
+        if (title != nil) {
+            NSLog(@"Ti.Facebook.presentMessengerDialog.title has been deprecated in Ti.Facebook 5.5.0 as of the Graph v2.9 changes.");
+            content.contentTitle = title;


@Property (nonatomic, readonly) NSString *contentTitle
DEPRECATED_MSG_ATTRIBUTE("contentTitle is deprecated from Graph API 2.9");

contentTitle has changed to read only, but you are assigning to it. It is giving build error. Please remove it.

vijaysingh-axway · 2017-07-20T07:23:32Z

ios/Classes/FacebookModule.m

+
+        if (picture != nil) {
+            NSLog(@"Ti.Facebook.presentMessengerDialog.picture has been deprecated in Ti.Facebook 5.5.0 as of the Graph v2.9 changes.");
+            content.imageURL = [NSURL URLWithString:picture];


As per FBSDKShareLinkContent.h -

@Property (nonatomic, readonly) NSURL *imageURL
DEPRECATED_MSG_ATTRIBUTE("imageURL is deprecated from Graph API 2.9");
imageURL has changed to read only, but you are assigning to it. It is giving build error. Please remove it.

vijaysingh-axway · 2017-07-20T07:24:28Z

ios/Classes/FacebookModule.m

+
+        if (description != nil) {
+            NSLog(@"Ti.Facebook.presentShareDialog.description has been deprecated in Ti.Facebook 5.5.0 as of the Graph v2.9 changes.");
+            content.contentDescription = [params objectForKey:@"description"];


As per FBSDKShareLinkContent.h -
@Property (nonatomic, readonly) NSString *contentDescription
DEPRECATED_MSG_ATTRIBUTE("contentDescription is deprecated from Graph API 2.9");

contentDescription has changed to read only, but you are assigning to it. It is giving build error. Please remove it.

hansemannn · 2017-07-21T20:28:35Z

@vijaysingh-axway Thanks for the feedback, I've eliminated all of them!

hansemannn · 2017-07-22T22:40:55Z

Hey @vijaysingh-axway, this unintentionally ended in basically rewriting the whole module. This includes:

Moved to ARC
Exposed public API's to headers
Added nullability-specification
Rename parameter to human-readable ones

vijaysingh-axway

CR passed.

hansemannn · 2017-08-10T06:27:00Z

@garymathews Double-checking: Can we merge this? iOS is ready, Android seems to be approved by you as well. Thanksss!

garymathews

CR: PASS

hansemannn · 2017-08-17T11:48:21Z

@ewieberappc Can we do a FT before merging here? I feel we are more save to test the packaged modules before. It's provided above!

hansemannn · 2017-08-21T16:11:58Z

Side-note: CI fails because it tries with master, which requires the V8 upgrade for Android, so not related to this PR.

mukherjee2

Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.3
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0.v20170823150008
Appcelerator Studio, build: 4.9.1.201707200100
Xcode 8.3.2
Ti Facebook Module 6.3.0 for Android

FR passed for Android. I used the latest module, and was able to use the module with a Facebook app that I created.

hansemannn added 2 commits March 18, 2017 11:10

Update Android Facebook SDK to 4.20.0

5777580

Update iOS Facebook SDK to 4.20.2

2e0ddfd

hansemannn changed the title ~~Update Android Facebook SDK to 4.20.0~~ Update Android Facebook SDK to 4.20.0, iOS SDK to 4.20.2 Mar 18, 2017

hansemannn and others added 5 commits March 24, 2017 20:34

Merge branch 'master' into update-android-fb-sdk

76d66c0

Merge branch 'master' of github.com:appcelerator-modules/ti.facebook …

02efd26

…into update-android-fb-sdk

Merge branch 'master' into update-android-fb-sdk

ad5f311

Merge branch 'update-android-fb-sdk' of github.com:hansemannn/ti.face…

aad15d7

…book into update-android-fb-sdk

Update Facebook iOS-SDK to 4.22.0

b72c773

hansemannn changed the title ~~Update Android Facebook SDK to 4.20.0, iOS SDK to 4.20.2~~ Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 Apr 18, 2017

Update Android-SDK to 4.22.0, document deprecation

8e0c60e

hansemannn requested review from garymathews and vijaysingh-axway April 18, 2017 20:03

hansemannn changed the title ~~Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 Apr 18, 2017

hansemannn added 2 commits April 18, 2017 22:22

Fix header search paths

63070bc

Support the Facebook Places SDK

c720a06

hansemannn changed the title ~~[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 + Places SDK Apr 23, 2017

hansemannn changed the title ~~[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 + Places SDK~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 + FBSDKPlacesKit API Apr 23, 2017

hansemannn and others added 4 commits April 23, 2017 16:26

Update Facebook.yml

dd16a05

Fix example

51efc71

Update iOS-SDK to 4.23.0

81a7d0b

Update Android-SDK to 4.23.0, use AAR library

88568b9

hansemannn changed the title ~~[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.22.0, support Graph v2.9 + FBSDKPlacesKit API~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.23.0, support Graph v2.9 + FBSDKPlacesKit API Jun 21, 2017

garymathews approved these changes Jun 22, 2017

View reviewed changes

Update manifest

30bfc4d

vijaysingh-axway reviewed Jul 20, 2017

View reviewed changes

Fix deprecated API's, move share-content to util

d2d8056

hansemannn added 6 commits July 21, 2017 13:45

Update to Facebook iOS SDK 4.24.0

e5626d2

Group classes

ca59d50

Refactor format, update copyright

a5a44f5

Use ARC, refactor project, all nullable-specifiers

c22c3c0

Add missing nullability-and type-specifiers

6707eca

Expose public API's to header, more nullability

658c155

hansemannn added 2 commits July 23, 2017 14:20

Update to Facebook Android SDK 4.24.0

ca0ea9e

Add proper code-docs for FacebookModule class

0f46e52

hansemannn changed the title ~~[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.23.0, support Graph v2.9 + FBSDKPlacesKit API~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.24.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project Jul 23, 2017

hansemannn added 3 commits July 23, 2017 17:40

Migrate to new "titanium-facebook", more docs!

5b98912

Final iOS touches

716ca82

Refactor alle examples

bb83d07

vijaysingh-axway approved these changes Jul 24, 2017

View reviewed changes

garymathews approved these changes Aug 17, 2017

View reviewed changes

hansemannn added 5 commits August 17, 2017 17:34

Update Facebook iOS-SDK to 4.25.0

77f22fd

Update Android SDK to 4.25.0

d4a94ff

Build iOS with 6.1.2.GA

a31078a

Hardcore versions for now

f1c989f

Fix framework-search-paths

e5334f9

hansemannn self-assigned this Aug 21, 2017

hansemannn changed the title ~~[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.24.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project~~ [TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project Aug 21, 2017

mukherjee2 self-requested a review August 24, 2017 23:23

mukherjee2 approved these changes Aug 24, 2017

View reviewed changes

hansemannn merged commit 85d2724 into tidev:master Sep 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project #85

[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project #85

hansemannn commented Mar 18, 2017 •

edited

hansemannn commented Jun 21, 2017

garymathews commented Jun 21, 2017 •

edited

garymathews left a comment

vijaysingh-axway Jul 20, 2017 •

edited

vijaysingh-axway Jul 20, 2017 •

edited

vijaysingh-axway Jul 20, 2017

vijaysingh-axway Jul 20, 2017

hansemannn commented Jul 21, 2017

hansemannn commented Jul 22, 2017

vijaysingh-axway left a comment

hansemannn commented Aug 10, 2017

garymathews left a comment

hansemannn commented Aug 17, 2017 •

edited

hansemannn commented Aug 21, 2017

mukherjee2 left a comment

[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project #85

[TIMOB-24593] Update Facebook Android SDK + iOS SDK to 4.25.0, support Graph v2.9 + FBSDKPlacesKit API, refactor iOS-project #85

Conversation

hansemannn commented Mar 18, 2017 • edited

hansemannn commented Jun 21, 2017

garymathews commented Jun 21, 2017 • edited

garymathews left a comment

Choose a reason for hiding this comment

vijaysingh-axway Jul 20, 2017 • edited

Choose a reason for hiding this comment

vijaysingh-axway Jul 20, 2017 • edited

Choose a reason for hiding this comment

vijaysingh-axway Jul 20, 2017

Choose a reason for hiding this comment

vijaysingh-axway Jul 20, 2017

Choose a reason for hiding this comment

hansemannn commented Jul 21, 2017

hansemannn commented Jul 22, 2017

vijaysingh-axway left a comment

Choose a reason for hiding this comment

hansemannn commented Aug 10, 2017

garymathews left a comment

Choose a reason for hiding this comment

hansemannn commented Aug 17, 2017 • edited

hansemannn commented Aug 21, 2017

mukherjee2 left a comment

Choose a reason for hiding this comment

hansemannn commented Mar 18, 2017 •

edited

garymathews commented Jun 21, 2017 •

edited

vijaysingh-axway Jul 20, 2017 •

edited

vijaysingh-axway Jul 20, 2017 •

edited

hansemannn commented Aug 17, 2017 •

edited