Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): update for Android 12 #192

Merged
merged 8 commits into from Sep 1, 2021
Merged

chore(android): update for Android 12 #192

merged 8 commits into from Sep 1, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jul 17, 2021 •
edited

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28478

Android Changes:

  • Add immutable/mutable flag to pending intent. (Prevents exception on Android 12.)
  • Add "course" location permission to manifest. (Required by Android 12 when requesting "fine" permission.)
  • Fixed example code crashes on Android.
  • Updated module version to 5.0.1.

iOS Changes:

  • Updated module version to 4.0.0.
  • Dropped 32-bit support.
  • Changed min Titanium SDK version to 10.0.0.

@build
Copy link

build commented Jul 17, 2021 •
edited

Fails
🚫 version bump was Major in android/manifest but Patch in package.json
Warnings
⚠️ SDK version declared in Jenkinsfile (10.1.0.v20210820083427) does not match iOS' titanium.xcconfig value (10.0.2.GA)
Messages
📖 🎉 - congrats on your new release
📖

✅ All tests are passing
Nice one! All 26 tests are passing.
📖

💾 Here are the artifacts produced:

Generated by 🚫 dangerJS against eb41177

garymathews
garymathews reviewed Jul 21, 2021
View reviewed changes
android/manifest Outdated Show resolved Hide resolved
garymathews
garymathews approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@lokeshchdhry lokeshchdhry merged commit 33e79bf into tidev:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @lokeshchdhry @garymathews