Add support for polylines and polygon

[muka]

Hi,
I've added support for polylines and polygon in my fork
https://github.com/muka/ti.map/tree/master/android/src/ti/map

Hope could be merged in the main repository.

Regards

[muka]

Added either circle support and on click events (for polygon & polyline)

[andersdp]

Would be really great if this made it in to the main repository...

[ingo]

@muka We'd be happy to review this if you could do three things:

1. Sign the CLA (http://developer.appcelerator.com/cla)
2. Create a ticket in JIRA for the change so we know what it is and how to test it
3. File a PR against the repository.

Thanks!
Ingo

[muka]

Dear @ingo

1 Sorry, I don't see the reason to sign a document for a small contribution like this, could you explain me why I should sign?
2 Ticket is here https://jira.appcelerator.org/browse/TIMOB-15410
3 The PR would be incomplete as my fork cover only Android, but there is an IOS version (thanks to @astjohn) with a compatible API https://github.com/Sitata/ti.map/tree/drawing
I'd be happy to pack everything but, at the moment, I do not have nor the time nor the capabilities to do that..

Thanks!
Luca

[astjohn]

@ingo - We can get this finished up in a few days from the Sitata fork. We've been testing polygons in particular pretty extensively, with the "old" google play services and the new. It's pretty much good to go.

@muka - thanks for reminding me about this. Were you able to clean up the android stuff a bit more? I will be happy to pull in your changes and formally submit this.

[muka]

Hi @astjohn
Great! I've not yet cleaned it up, but let me a few days to finish it.
Thanks

[mikedias]

👍

[astjohn]

@mikedias - We currently have a branch that you might want to check out that is more or less in stable condition.

https://github.com/Sitata/ti.map/tree/drawing_longpress_fix_ios

This branch add drawing support, but also:

• Fixed the longpress event on iOS.
• Fixed the fact that the "region" property was not updating on android during map pan events as iOS does.
• Added dependency on 3.5.0.GA for ios8/64bit support.

I did notice that with 3.5.0.GA, @muka's click additions to shapes on Android no longer works. He's aware and working on a fix. Then I think we'll be ready to pull this into appcelerator if they accept it.

[mikedias]

Hi @astjohn, thank you for the tip! I hope to see this branch in the official releases soon!

[muka]

@astjohn all good from my side!

For some obscure reasons using JSON.stringify / console.log to serialize the event object from the click callback seems to freeze the execution context (probably due to some kind of recursion?)
If there is a feedback on this I'll be happy to investigate further

master branch in https://github.com/muka/ti.map is up to date
If there are no more issues, 👍 to proceed!

[yozef]

@muka Works nicely :)

[astjohn]

@muka, Thanks. Will be submitting now. Sorry it took me so long to finally wrap this up.