[TIMOB-19215] Fix click events #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How's this going? I tried this PR version and still go no click events. thx. |
|
@kosso : The PR ist in progress, we will merge and release a new version asap. |
|
APPROVED. merging. |
cheekiatng
added a commit
that referenced
this pull request
Aug 13, 2015
[TIMOB-19215] Fix click events
| `subtitle`, `leftPane`, `rightPane`, `infoWindow` or `null`. If the user clicks anywhere in | ||
| the info window other than `title`, `subtitle`, `leftPane` or `rightPane`, the | ||
| `clicksource` will be `infoWindow`. If the user deselects an annotation | ||
| The `click` event includes a value, `clicksource`, which describes the part of the annotation that was clicked. The `clicksource` can be one of `pin`, `leftButton` or `rightButton` on iOS and pin`, `title`, `subtitle`, `leftPane`, `rightPane`, `infoWindow` or `null` on Android. If the user deselects an annotation |
There was a problem hiding this comment.
Typo here:
on iOS and pin`, Requires a starting back-tick at the pin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(In progress)
JIRA: https://jira.appcelerator.org/browse/TIMOB-19215